microsoft/CLRInstrumentationEngine

merge module errors (msm)

sanikolov opened this issue · 2 comments

sanikolov commented

I have only a single msm (the 64 bit one) in my wxs definition, shown below

    <Directory Id="TARGETDIR" Name="SourceDir">
      <Directory Id="ProgramFiles64Folder" Name="ProgramFiles64Folder">
        <Directory Id="ProgramFiles64Folder.Vendor" Name="Company">
          <Directory Id="INSTALLDIR" Name="ProductName">
            <Merge Id="clrie64" FileCompression="yes" Language="1033" SourceFile="instrumentationengine.module_x64.1.0.42.msm" DiskId="1" />

The definition above elicits these errors.

light.exe : error LGHT0204: ICE80: This 32BitComponent DiagnosticsExtensionsBase32.1.0.42.20EA0D19_C444_4B21_BC84_BF871AFDE394 uses 64BitDirectory base32.20EA0D19_C444_4B21_BC84_BF871AFDE394
light.exe : error LGHT0204: ICE80: This 32BitComponent ExtensionsBase32.1.0.42.20EA0D19_C444_4B21_BC84_BF871AFDE394 uses 64BitDirectory base32.20EA0D19_C444_4B21_BC84_BF871AFDE394
light.exe : error LGHT0204: ICE80: This 32BitComponent Config32.1.0.42.20EA0D19_C444_4B21_BC84_BF871AFDE394 uses 64BitDirectory base32.20EA0D19_C444_4B21_BC84_BF871AFDE394
light.exe : error LGHT0204: ICE80: This 32BitComponent InstrumentationEngine32.1.0.42.20EA0D19_C444_4B21_BC84_BF871AFDE394 uses 64BitDirectory Instrumentation32.20EA0D19_C444_4B21_BC84_BF871AFDE394
light.exe : error LGHT0204: ICE80: This 32BitComponent InstrumentationEngineProxy32.1.20EA0D19_C444_4B21_BC84_BF871AFDE394 uses 64BitDirectory ProxyVersion32.20EA0D19_C444_4B21_BC84_BF871AFDE394

Any thoughts on this?

WilliamXieMSFT commented

Hi @sanikolov, appreciate you trying this scenario out. The msm file has a similar directory structure setup, and I assume is causing conflicts:
https://github.com/microsoft/CLRInstrumentationEngine/blob/main/src/InstrumentationEngine.Installer/Common/Wixlib/directories.wxi

Can you try moving the <Merge /> node under TARGETDIR?

<Directory Id='TARGETDIR' Name='SourceDir'>
  <Merge Id="clrie64" FileCompression="yes" Language="1033" SourceFile="instrumentationengine.module_x64.1.0.42.msm" DiskId="1" />
sanikolov commented

good suggestion. I was in a mad rush last night to meet self imposed deadlines and couldn't think straight.
Btw thanks for creating merge modules. In general they are best avoided but due to limitations in bootstrappers based on burn and their interactions with EmbeddedUI in wix 3.x based MSIs they are invaluable.