microsoft/ChakraCore-Debugger

Need code to compile using C++17

akrantz opened this issue · 4 comments

websocketpp does not build with C++17. zaphoyd/websocketpp#669

I made a branch which enables the projects to build using C++17: https://github.com/akrantz/ChakraCore-Debugger/tree/c%2B%2B17

Changing websocketpp to use the develop branch will allow it to build.

See https://github.com/akrantz/ChakraCore-Debugger/tree/c%2B%2B17-fixes.

Is this a requirement for your usage? Ideally we'd like to avoid taking a dependency on the develop branch.

Well I tried to specify the compiler flag to use C++14 but I wasn't successful. I made more progress by switching to the websocketpp develop branch. It would be ideal if we could get websocketpp master branch to build with C++17, whether by having the develop branch merged in, or possibly having a more targeted fix to replace std::auto_ptr with std::unique_ptr.

There is also one other issue that I ran into which was needed to link in a winsock dll for GetAcceptEx and GetSocketAddrs [??? I don't remember the exact function name]. I wasn't sure if I could avoid that in websocketpp. Might be easier to chat directly about these issues.

Defining _HAS_AUTO_PTR_ETC allows the code to build with C++17. #35