Add possibility to verify Template Package Signature to Core
sibille opened this issue · 3 comments
We're using PackageDigitalSignatureManager(https://docs.microsoft.com/en-us/dotnet/api/system.io.packaging.packagedigitalsignaturemanager) to sign the template package and verify it's signature based on the Open Packaging conventions. This class is contained in the WindowsBase.dll and not available on .net standard 2.0.
To be able to verify signatures from Windows Template Studio, the corresponding code was moved to the Utilities framework.
Once this is available (hope is .NET 5) we should move this functionality back to the Core project so Web Template Studio can consume it too.
Hello @sibille,
My organization is using the CoreTemplateStudio for some VSCode extensions with project generators. I was trying to move as much as possible to node and net core. I also had to migrate the old .API to net core 3.1 (it is an old fork).
So I was wondering can you share more information if/when you plan to move to .NET 5.0?
Also do you have plans to make the WtsPackagingTool a cross platform console application that can be built and run on Mac or Linux? Some of our web developers work on Mac OS or Linux, currently we package the templates on build machines and they can get the dependencies and work locally on the web UI for VSCode, but it would be awesome if the build for whole CoreTemplateStudio can be handled by the dotnet on Mac and Linux.
Thanks,
As CoreTemplateStudio.Core is .NetStandard2.0 it shouldn't be limited on where it runs.
If Utilities was converted into a .netStandard library that should enable the conversion of WtsPackagingTool.
The biggest potential block to a full conversion is the strong coupling between CoreTemplateStudio and WindowsTemplateStudio which only runs in Visual Studio.
Because VS17 is still only on .NET Framework (v4.8 & not Core) I'm not expecting that it'll be possible to convert everything from the .NET Framework until the coupling between CTS and WTS is lessened.
As @mrlacey mentioned we can't update CoreTemplateStudio to .NET 5 as it is used in WindowsTemplate Studio which is a Visual Studio extension that requires .NET Framework.
Utilities can't be moved to .NET Standard as it contains code using the PackageDigitalSignatureManager which is only available on Windows.