microsoft/DefendTheFlag

Names are incorrect on DSC Script for Users

chboeh opened this issue · 2 comments

Example:

	xADUser SamiraA
	{
		DomainName = $DomainName
		UserName = 'SamiraA'
		Password = $SamiraACreds
		Ensure = 'Present'
		GivenName = 'Samira'
		Surname = 'A'
		PasswordNeverExpires = $true
		DependsOn = @("[xADForestProperties]ForestProps", "[xWaitForADDomain]DscForestWait")
	}

Needs to be updated to:

	xADUser SamiraA
	{
		DomainName = $DomainName
		UserName = 'SamiraA'
		Password = $SamiraACreds
		Ensure = 'Present'
		GivenName = 'Samira'
		Surname = 'Abbasi'
		PasswordNeverExpires = $true
		DisplayName = 'Samira Abbasi'
		DependsOn = @("[xADForestProperties]ForestProps", "[xWaitForADDomain]DscForestWait")
	}

Submitted "pull request'

Updated Jeff Leatherman and Samira Abbasi for appropriate Surname and Display name