microsoft/HealthBotContainerSample

Improve Health Probe to Verify APP_SECRET

Closed this issue · 3 comments

ericmaino-automation commented

The health probe confirms the WEBCHAT_SECRET is valid by obtaining a direct line token however it does not verify the APP_SECRET.

It could send a simple INIT/END conversation as part of the probe when it is in an unhealthy state

amir-microsoft commented

Hi @ericmaino, by design, the server doesn't communicate with the bot, and only generate tokens.
It will be pretty complicated to have it send the event to the bot, and more than that, actually verify that the the JWT was valid.
And on the other hand, if the bot is configured to enable "end user authentication", it will surface immediately in the client.

I suggest to leave it as it is for now.
Thanks!

ericmaino commented

@amir-microsoft understood. I took a moment to explore this today and submit a PR that will address it. Understood if it doesn't meet the bar at the moment.

amir-microsoft commented

Thanks @ericmaino !
It looks like it will work, but for now I don't think this functionality is required in the server side, and I wish to keep it as simple as possible.
I will close the PR now, we can revisit this in the future.

Thank again