Submodules are bad and defaulting to https
IanLeeClaxton opened this issue · 2 comments
Thanks for the invite to join this repo!
I use SSH but when I clone this repo the submodules are listed as https so I get a request for a username and password. For some reason (I assume 2FA), I'm unable to sign-in so unable to update the submodule.
Maybe I'm doing something wrong but I've never been a fan of submodules and while I can see the use-case here, I think this could lead to more issues and reduced usage of this repro.
Ian
I resolved the issue by editing the .git/config file direct but maybe you should include some information about submodules in the readme. This is the first time I have used them in 25 years of professional development as I prefer the package approach. I'm sure with pip you can reference a git repo and update when needed.
I have updated the file .git/config as follows.
[submodule "7B_FT_float32"]
active = true
url = git@github.com:microsoft/Llama-2-Onnx-7-FT-32.git
git submodule update
Cloning into '/Users/xxx/xxx/Llama-2-Onnx/7B_FT_float32'...
Submodule path '7B_FT_float32': checked out 'b0c079914d04b5e18e890b0db5cf29ede258f613'
I don't see the expected 10GB onnx file. Do I miss something?