microsoft/PowerToys

Upgrade any .NET Framework area to .NET Core 3

crutkas opened this issue · 15 comments

crutkas commented

.NET Core 3 upgrade

Update all sections that use .NET to .NET Core 3

.NET Framework 4.7.2

  • ColorPicker <- done by @snickler
  • MarkdownPreviewHandler <- #8405
  • PreviewHandlerCommon <- #8405
  • SvgPreviewHandler <- #8405
  • SVGThumbnailProvider <- #8405

Tests

  • Microsoft.Interop.Tests <- done by @eriawan
  • PreviewPaneUnitTests <- #8405
  • UnitTests-PreviewHandlerCommon <- #8405
  • UnitTests-SvgPreviewHandler <- #8405
  • UnitTests-SvgThumbnailProvider <- #8405
  • PowerToysTests <- done by @riverar WinAppDriver tests

.NET Standard 2.0

  • Managed Common
  • Telemetry
  • Settings.UI.Library
  • PowerLauncher.Telemetry

.NET Core 3.1

  • FancyZonesEditor
  • Settings.UI.Runner
  • Settings.UI.UnitTests
  • UnitTest-ColorPicker
  • ImageResizerUI
  • ImageResizerUITests
  • PowerLauncher
  • Wox.Infrastructure
  • Wox.Plugin
  • Wox.Test

UWP

  • Settings.UI

Things to include

enricogior commented

This issue has a pre-requisite #866

We PR is ready but not merged because of the pending dependency.

enricogior commented

Added the resolved label since on our side this is done.
Added the external label to indicate we are waiting of an external dependency to be available.

yuyoyuppe commented

We might need to revert this guy after the migration.

  • 👍1
enricogior commented

Moving to backlong since we don't know when .Net Core will be available in the store compared to our roadmap.

enricogior commented

We will adopt .Net Core 3.1

  • 👍1
haakoo commented

If #866 is solved, what's holding this back?

crutkas commented

@haakoo, doing it this iteration :) only so many hours in the day for the team and they were focusing on helping add in 4 new utilities and the 2 more new ones we will be shipping soon.

  • ❤️2
enricogior commented

For FancyZone editor is better to do it in 0.19

crutkas commented

This is needed for #490

crutkas commented

@davidegiacometti what item(s) are you working on? want to be sure we are not having anyone duplicating work

davidegiacometti commented

@crutkas

  • MarkdownPreviewHandler
  • PreviewHandlerCommon
  • SvgPreviewHandler
  • SVGThumbnailProvider
  • PreviewPaneUnitTests
  • UnitTests-PreviewHandlerCommon
  • UnitTests-SvgPreviewHandler
  • UnitTests-SvgThumbnailProvider
  • 👍2
enricogior commented

@davidegiacometti
please, open one PR per project, so it will be easier and faster to review and merge each one.
Thanks.

  • 👍1
snickler commented

I'll take on porting the Color Picker

  • 👍2
riverar commented

Will take a look at PowerToysTests <- WinAppDriver tests

  • 👍2
eriawan commented

I'm taking Microsoft.Interop.Tests migrate to .NET Core 3.1

  • 👍1