microsoft/Qcodes

Disabling auto_sweep in Keysight N52xx driver broken

spauka opened this issue · 2 comments

The auto_sweep function in the Keysight N52xx driver is broken. This feature allows data to be taken directly off screen without running a scan when disabled, which is necessary when measuring multiple parameters at once.

It looks like the check for auto_sweep was accidentally disabled in commit 78a989f

Expected Behaviour

When running the below snippet the PNA should only take a single measurement

pna.auto_sweep(False)
qc.dataset.do0d(pna.magnitude, pna.phase)

Actual

The pna will run the trace twice, once for magnitude and once for phase.

@jenshnielsen

Thanks @spauka Not that it matters but I think the commit that brok it was jenshnielsen@3c12a28

Haha right - no it doesn't matter and it's an easy fix. Thanks for looking at it so quickly :)