Making use of git submodules
RobinVdBroeck opened this issue · 3 comments
Could we make use of submodules? When you want to clone an example you have to clone all the examples at the moment. If submodules were used you would have to option to either
a. Clone all the projects using git clone --recursive
b. Clone just one project
Hey @GamesMaxed, I'd be inclined to agree if submodules themselves were a little more fluid and didn't impose a learning curve on people who wanted to quickly peek into a sample/people who aren't familiar with submodules in general. I don't want people to try cloning the repo and, because they didn't read the instructions, not realize what they did incorrectly. I'd prefer if things just worked from the get-go.
There's also a maintenance cost for us to bump up revisions every time someone changes a sample. While not the hardest thing to deal with, that's something I already do manually with several other repos, and I'd rather avoid adding another.
Overall, the size of this repo is pretty small. Is this really an inconvenience?
@DanielRosenwasser :
Firstly, I agree with you that it may be harder and rather discouraging for people who are inexperienced with git. However, this may also be a learning experience for these people. Not only will they (hopefully) learn something new about typescript, they will also learn about this new awesome feature of Git.
That being said tough, I don't think that this learning experience outweighs the disadvantages that you summed up in your comment.
To finish this comment tough, I would like to give an advantage of git submodules that most people seem to forgot that is not applicable to this repo. In a lot of countries, including developing countries where people really need to develop this kind of skills to have a better future, the internet is really slow and they got limited bandwidth. This may lead to people being unable to clone a repo because of his size. This may be fixed in some cases by the use of git submodules. An example would be this repo if the projects were a lot bigger in size. The guy/girl in this country could juse clone the repo he wanted then. Ofcourse, there are other solutions to this problem like just viewing the source code on github. But even with this other methods I still personally find it really important and hope you guys take it into consideration for future projects.
git submodules is a good option.