microsoft/VSExtensibility

Dependent VSIX is not installed in Visual Studio 2022 Preview 17.3.1

WardenGnaw opened this issue · 6 comments

Originally from: microsoft/MIEngine#1316
by @sangwook96


Hi
I am a developer for Tizen App.
During working, we got one issue.
In Visual Studio 2022 Community Preview (17.3.0 Preview 1.1), we tried to install https://marketplace.visualstudio.com/items?itemName=tizen.VSToolsTizen2022 (3.6.0.0)
After completing to installation, I find out the one issue.
“Visual Studio Tools for Tizen” has Tizen MIEngine internally
When a user installs “Visual Studio Tools for Tizen” vsix, “Visual Studio Tools for Tizen” tries to install embed MIEngine together.
Normally, After completion of the installation, we can see both “Visual Studio Tools for Tizen” and “Tizen MIEngine” libraries.
There is no issue till Visual Studio 17.2.3
But On the 17.3.X preview version, After installation the vsix, we can see both “Visual Studio Tools for Tizen” extension libraries but we can not see Tizen_MIEngine libraries.

As we analyzed, we find out the below steps.

Install “Visual Studio Tools for Tizen” extension libraries
Install Tizen_MIEngine libraries.
Execute vsfinalizer.exe
After that, Tizen_MIEngine libraries were deleted => It’s the issue which we ask you.
I also update in detail vsfinalizer.exe’s command lines.
Executing: “C:\Program Files\Microsoft Visual Studio\2022\Preview\common7\ide\vsfinalizer.exe” -Operation Modify -SKU Community -InstallationID 975af454 -InstallationName VisualStudioPreview/17.3.0-pre.1.1+32519.111 -InstallationVersion 17.3.32519.111 -InstallationWorkloads Microsoft.VisualStudio.Workload.CoreEditor,Microsoft.VisualStudio.Workload.NetCrossPlat,Microsoft.VisualStudio.Workload.ManagedDesktop,Microsoft.VisualStudio.Workload.NativeDesktop,Microsoft.VisualStudio.Workload.VisualStudioExtension -InstallationPackages

We make a workaround to debug it on the preview version(17.3.x), too
Workaround
src/MIDebugPackage/source.extension.vsixmanifest // Tizen MIEngine project
We changed from to

src/Tizen.VisualStudio.VsixSetup/source.extension.vsixmanifest // Visual Studio Tools for Tizen
We changed from to

src/Tizen.VisualStudio.VsixSetup/Tizen.VisualStudio.VsixSetup.csproj // Visual Studio Tools for Tizen
Removed the lines

$(GetVsixSourceItemsDependsOn);AddToVsixSources

<_Contents Include=“$(OutputPath)\DeployedContents**” />

Tizen\VisualStudio%(_Contents.RecursiveDir)
MSBuild

We can reproduce it in the sample projects also using the following steps,

Create a sample dependent C# vsix project from the project wizard, change the option in source.extension.manifest file to allusers=true (e.g - )and generate vsix.
Create a sample main C# vsix project, change the option to allusers=true in source.extension.manifest file(e.g - ), copy the dependent vsix generated above, add dependency as embedded VSIX, and create main VSIX.
example code,

<Dependency Id=“Microsoft.Framework.NDP” DisplayName=“Microsoft .NET Framework” d:Source=“Manual” Version=“[4.5,)” />


Installation in Visual studio 2022 17.2.3 version
-> Both the main and dependent VSIX is installed.

Installation in Visual Studio 2022 Preview 17.3.1 version
-> Only the main VSIX is installed, the dependent VSIX is not installed.

For the Official version like community or professional,
we need to have AllUsers=“true”
If there is no AllUsers=“true” on the vsix, we can not install the vsix.

But for preview version like community preview (17.3.x)
we should not have AllUsers=“true”
If there have AllUsers=“true” on the vsix, we can not debug tizen.net app

Could we use AllUsers=“true” on the preview version, too?

Thanks

@WardenGnaw
Hello,
Thank you very much for taking it up.
Do you have any progress or if you are not an owner, could you assign it to others?
We are waiting for it.
Thanks

@WardenGnaw
Hi,
We are tracking the previous history on the website.
Actually, it occurs on the preview version(17.3.x) but I worry if it happens on product version(17.3.X) like professional and community
Thank you very much for considering our issue and we need your help.

@leslierichardson95 can you or someone on the extensibility team answer this question?

Thanks!

@WardenGnaw, @leslierichardson95
Hi,
Thank you very much.

https://developercommunity.visualstudio.com/t/Deleted-MIEngine-libraries/10067461?space=8&q=miengine
A fix for this issue has been released! Install the most recent release from https://visualstudio.microsoft.com/downloads/. Thank you for providing valuable feedback which has helped improve the product.

I tested it on the below version but I still have the same issue.
Microsoft Visual Studio Community 2022 (64-bit) - Preview
Version 17.3.0 Preview 2.0

If it was fixed, could you tell us the VS version?
Thanks

@matthew-j-clark
Hello,
Could you help us, too?
https://developercommunity.visualstudio.com/t/Deleted-MIEngine-libraries/10067461?space=8&q=miengine
A fix for this issue has been released! Install the most recent release from https://visualstudio.microsoft.com/downloads/. Thank you for providing valuable feedback which has helped improve the product.
I can see your comment and I really appreciate it.
You updated that it was fixed in Visual Studio 2022 version 17.2.5

But we reported it on 17.3 previews 1.1 version, now 17.3 previews 2.0 version has still the issue.
Is it fixed on 17.2.5?
Then, excuse me, what did you fix it or where can I see the patchset for it?

Thank you very much for supporting our issue
Thanks

Hello @sangwook96 @WardenGnaw I have validated that this is fixed in 17.3 and 17.4. A note, that because the debugging extension is nested, it will not show up in the extension list. I was able to step through for a double check and ensure it is present on disk and registered with VS. Please let me know if you need more information!