microsoft/YamUI

Right rail modules need to have a padding-top

Closed this issue · 5 comments

allobast commented

Right rail modules need to have a padding-top before the title allowing to stack modules on top of each other without playing with margins (so it's consistent).

image 1

unindented commented

@allobast couldn't you wrap them in a Block with top padding? Why do you need AsideSection itself to have a prop for padding?

  • 👍1
allobast commented

Adding @adrianmg as he provided designs for this.

unindented commented

I think designers won't care how we implement this, as long as it looks the way it should. So you could totally have something like this (adjust GutterSize to whatever you need):

<Block topSpacing={GutterSize.LARGE}>
  <AsideSection title="Example title">
    <div>Child Content</div>
  </AsideSection>
</Block>
  • 👍1
allobast commented

Oh I see what you're saying! Sure, makes sense!

swese44 commented

ya this should be handled by the layout which renders AsideSection, not AsideSection itself

  • 👍1