Rename badge icons
Closed this issue · 6 comments
These are probalby tied a bit too close to Yammer business logic, can we rename them to reflect their content rather than the intended user on Yammer.com?
I think just the 3 badge icons:
- BadgeAdmin - This uses FavoriteStar, how about CircleFavoriteStar?
- BadgeFlexternal - This uses Globe, how about CircleGlobe?
- BadgeNew - This looks like it uses Fabric's Emoji2 icon, maybe CircleEmoji2? not sure about this one
in Fabric land does 'coin' mean 'circle'?
In FabricLand, Coin is the (usually-)circular avatar/image part of a Persona - Persona being the image plus the accompanying text. Example from https://developer.microsoft.com/en-us/fabric#/components/persona
I can't find anything with coin on Fabric icon set though
Name nit-picking: I'd suggest CircleStar, CircleGlobe, CircleFace or similar - sticking with describing the shape. 'Favorite' implies policy as much as 'Admin' does, while Emoji2 is an impl detail.
I'm taking a look at other icons and we're using 'circle' extensively. Also, we're mixing different approaches: some icons have the action as the name and others are more focused on the shape.
Until now, we've been literally respecting the original Fabric Iconography naming to avoid duplicates and confusion as much as possible (we're copying/forking their icon most of the time).
Updated names for badge icons to:
- CircleFavoriteStar
- CircleGlobe
- CircleEmoji2