microsoft/YamUI

Aside Section Visual Diff Test is Flakey

Closed this issue · 1 comments

I see this test fail roughly 1/5 times when running: y run test:visual

config/styleguide-visual/reference/AsideSection_basic_desktop.png

They are slightly different heights.

Original:
image

New:
image

Using slowMo to slow down puppeteer further would probably mitigate this.

To repro more consistently, you can probably reduce the slowMo value.
https://github.com/Microsoft/YamUI/blob/454b581951d09b96835c7ac617e6f62bdb927fe5/config/styleguide-visual/config.js#L16

This was fixed in #379