17.6 Text spacing helper flaw
peterlukerow opened this issue · 2 comments
Description
The styling injected by 17.6 when you enable the text helper is not specific enough and ends up giving a false positive of failure when in fact the site is fine.
In this specific case it is the line height that does not get altered.
To Reproduce
Steps to reproduce the behavior:
- Go to https://www.communitydirectory.norfolk.gov.uk/
- Enable the extension and/or click the extension button on next to address bar.
- Choose Assement option.
- Scroll to and expand 17 adaptable content and then click 17.6 Text spacing
- Turn on the visual helper
Expected behavior
The letter spacing, word spacing, line height and space after paragraphs should change.
Screenshots
Using extensions
If I used a JS bookmarklet from https://codepen.io/stevef/pen/YLMqbo and toggle it on then I get the following as expected:
Context (please complete the following information)
- OS Name & Version: Windows 11 22H2 (Build 22621.1413)
- AI-Web Version & Environment: v2.373 (official release)
- Browser Version: MS Edge 113.0.1769.0 (canary 64 bit) and Google Chrome 111.0.5563.147 (Official Build) (64-bit)
- Target Page: https://www.communitydirectory.norfolk.gov.uk/
Are you willing to submit a PR?
I'm raising this merely because a client is using this tool to verify our work and is raising issues because of it.
Did you search for similar existing issues?
Yes
Additional context
The problem appears to be that the extension is injected styles that are not specific enough to various elements. The example JS bookmarklet applies styles to * and thus appears to have no issues.
This issue has been marked as ready for team triage; we will triage it in our weekly review and update the issue. Thank you for contributing to Accessibility Insights!
@peterlukerow This is a duplicate of an existing issue in our repo, #4800. We will be closing this issue but you can refer to the other one for updates!