[BUG] Dark mode menu overtheming in TextPattern Explorer
DaveTryon opened this issue · 4 comments
Describe the bug
The TextPattern explorer doesn't respond to dark mode theming, but the context menus are themed. In Prod, only the settings menus are themed; In Canary, the "..." context menu is also themed (this last change was caused by #1529).
To Reproduce
Steps to reproduce the behavior:
- Set your system to dark mode
- Run AIWin
- Open the Text Explorer dialog
- Click on the ... button or either of the gear buttons
Expected behavior
Context menus in unthemed dialogs should probably also be unthemed--they look a bit odd when they're mixed.
Actual behavior
The ideal (but unlikely) fix would be to theme the dialogs that are currently unthemed. Probably the more realistic fix would be to have an unstyled theme for context menus and use that from all unstyled dialogs.
Screenshots or .GIF
| Menu | Image |
|---|---|
| Range Settings |  |
| Attribute Settings |  |
| Text Settings |  |
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
- OS: Windows 11 22H2
- Accessibility Insights for Windows Version: 1.1.2312.1
Additional context
Priority requested -
Add any other context about the problem here.
This issue has been marked as ready for team triage; we will triage it in our weekly review and update the issue. Thank you for contributing to Accessibility Insights!
Note: we'd like to attempt the harder version of the fix (make the dialog(s) dark-mode compatible), but try to do it within a time box
Upon further investigation, this is significantly more work than we are prepared to invest at this time. WPF does not provide a good way to theme the dialog caption bar, and carrying the full theming through all of the actions and properties dialogs is something that does not fit into our current prioritized backlog. We're going to close this and leave it as is.
This issue has been marked as being beyond the support scope of Accessibility Insights. It will now be closed automatically for house-keeping purposes.