Visible rule and underscore values

Question

Visible rule and underscore values

gcacars opened this issue 4 years ago · 15 comments

I'm facing some problems with expressions in visibility rule that contains underscore in the values, like STANDARD_HA.

Environment

azure-pipelines-task-lib version: 2.9.6

Issue Description

Values with underscore not pass in the extension validation.

Expected behaviour

Expression should be validated without errors.

Actual behaviour

Error: Extension validation failed.

Steps to reproduce

Create a radio field:

    {
      "name": "tier",
      "type": "radio",
      "defaultValue": "BASIC",
      "options": {
        "BASIC": "standalone instance",
        "STANDARD_HA": "highly available primary/replica instances"
      }
    }

And other field with this visibleRule:
"visibleRule": "tier = STANDARD_HA"
Package and publish the extension

Logs

Task definition visible rule \'tier = STANDARD_HA\' is invalid. It should be of format "A <validconditionhere> B" for Task with ID ...

mindlessroman commented 4 years ago

not stale

👍2

mindlessroman commented 3 years ago

not stale

👍1

mindlessroman commented 3 years ago

not stale

Answer 1 · 2020-11-16T15:03:49.000Z

This issue has had no activity in 90 days. Please comment if it is not actually stale

Answer 2 · 2020-11-16T16:05:46.000Z

I also reported this to the product team and the rule on the marketplace is too strict. But I haven't seen a plan to resolve yet.

Answer 3 · 2020-11-16T17:43:41.000Z

Ok, but not makes sense for me to have a marketplace rule in the value of a field. It differs from a task name or extension id...

Answer 4 · 2020-11-16T17:59:55.000Z

I think it's some kind of security thing, haven't asked for the reason the rule exists, bu t I did ask for it to be removed.

…

On Mon, Nov 16, 2020, 18:43 Gabriel ***@***.***> wrote: Ok, but not makes sense for me to have a marketplace rule in the value of a field. It differs from a task name or extension id... — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#658 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA724S5LK4RTY2XHBRQCQATSQFQFXANCNFSM4QDR4MKQ> .

Answer 5 · 2020-12-23T22:29:22.000Z

I experienced the same problem when the value being tested has a #. None of the options below work:

"visibleRule":"lang=C#"
"visibleRule":"lang = C#"
"visibleRule":"lang=\"C#\""
"visibleRule":"lang = \"C#\""

Answer 6 · 2020-12-23T23:26:56.000Z

Got confirmation its a bug in the marketplace, but it's taking awfully long for the Azure Devops team to get the fix out.

If you manually push the task directly using tfx build tasks upload, the task will work just fine.

Answer 7 · 2021-03-26T14:01:39.000Z

This issue has had no activity in 90 days. Please comment if it is not actually stale

Answer 8 · 2021-07-28T10:02:41.000Z

This issue has had no activity in 90 days. Please comment if it is not actually stale

Answer 9 · 2021-10-26T18:01:21.000Z

This issue has had no activity in 90 days. Please comment if it is not actually stale

Answer 10 · 2021-10-29T06:20:52.000Z

Looks like the marketplace has relaxed validation on visibleRule.

Answer 11 · 2021-11-29T14:08:51.000Z

This is fixed now. Can be closed.

Answer 12 · 2022-02-27T15:01:41.000Z

This issue has had no activity in 90 days. Please comment if it is not actually stale