microsoft/azure-pipelines-vscode

Validation for stage names allows spaces when it should not

bbi-XavierElChantiry opened this issue · 3 comments

image
image
This issue presents when only the azure pipelines extension is enabled.
I am using version 1.195.0 of azure pipelines and version 1.63.2 of vs code.

Proof of concept that can be pasted into vscode to show issue

name: Spaces in a pipeline name

stages:
  # Does not warn that the name is invalid due to spaces!
  - stage: Space in stage name
    displayName: Spaces in a stage display name
    jobs:
      # Correctly warns that the name is invalid because it has spaces
      - job: Spaces in a job name
        displayName: Spaces in a job display name
        steps:
          - pwsh: |
              Write-Host "Inline Powershell script"
            # Correctly warns that the name is invalid because it has spaces
            name: Spaces in a step name
            displayName: Spaces in a step display name

Expected outcome: warning/error that the name is incorrect.
Actual outcome: false sense of security that the name is correct.

@bbi-XavierElChantiry Thanks for the issue-reporting in this repository, currently we are under issues with higher priority, we will take a look at this ticket once we will have enough capacity.

@EzzhevNikita would you recommend opening a ticket on Developer Community, since we just happen to be one of the consumers of the Azure DevOps yamlschema API endpoint, or is this issue sufficient?

@50Wliu Yes, it seems like the YAML schema requires changes to fix this issue.

@bbi-XavierElChantiry Could you please open a ticket in Developer Community since this issue requires changes in YAML schema, which is not owned by our team.