microsoft/azure-pipelines-vscode

Kubernetes@1 reports 'rollout' is not an accepted command when it is

mislavmatijevic opened this issue · 3 comments

mislavmatijevic commented

In short

Fix Kubernetes@1 job to accept command rollout.

More details

When a command "rollout" is used with Kubernetes@1 job, the extension reports "Value is not accepted" which is completely false: job works as intended.
Image
(reports "not accepted", however it does work)

This was already reported on StackOverflow 4 years by someone else: https://stackoverflow.com/questions/64268770/azure-devops-pipeline-kubectl-task-command-rollout-unavailable

I think this misinformation really needs to get fixed. I almost ended up thinking your Kubernetes job does not accept rollout command and that I'd have to use "delete" on pods found via labels instead of a normal, graceful rollout restart.

winstliu commented

Thanks for reporting @mislavmatijevic - sorry for the confusion. Could you please re-file this over at https://github.com/microsoft/azure-pipelines-tasks? That repo contains the completion definitions for individual tasks (see https://github.com/microsoft/azure-pipelines-tasks/blob/master/Tasks/KubernetesV1/task.json#L141-L154 which is missing the rollout command).

mislavmatijevic commented

Hello @50Wliu, thanks for such a quick response.

I noticed the enumeration of the command values for the Kubernetes@1 job without the rollout command in question on this repo and therefore opened an issue here. I'll open a new one on that other link. Thanks again!

mislavmatijevic commented

For anyone coming across this issue in the future, I reopened it here: microsoft/azure-pipelines-tasks#20562