microsoft/cpp-async

awaitable_resume_t.h does not compile on clang

Opened this issue · 3 comments

antoine-fresse commented

See https://godbolt.org/z/dWs91M7qE
Looks like whatever SFINAE trickery is used here compiles on GCC and MSVC but not clang

davidmatson commented

Thanks, @antoine-fresse for the bug report.

If you're able to submit a PR with a fix, we'd welcome the contribution. (I mainly use MSVC.)

pratikpc commented

@davidmatson this seems to be working

https://godbolt.org/z/GrdP8e6ja

I could try with the full project later.

Are there any plans by the way to switch to CMake for cross-platform support, given VS also supports CMake?

davidmatson commented

Thanks - I tried the link, but the code doesn't compiler with the project's current settings (compiled with MSVC with C++17 plus /await:strict; the project is currently target to supporting such callers).

We don't currently have plans to switch to CMake but could consider adding such support side-by-side with the current vcxproj/sln-based build.