microsoft/glTF-Toolkit

NDEBUG missing from Release configuration?

marpe opened this issue · 1 comments

marpe commented

Hi,

Shouldn't NDEBUG be set for Release builds?

https://github.com/Microsoft/glTF-Toolkit/blob/ee37a890c2cdcc20656d2ff3517332a815279965/glTF-Toolkit/glTF-Toolkit.vcxproj#L123

We're getting artifacts in our output when running in software mode otherwise (there seem to be some issues using a WARP device)

robertos commented

Yep, looks like a mistake when the project was consolidated (FYI @benbuzbee). Feel free to submit a PR if you have the bandwidth. Thanks!