microsoft/go-winio

github.com/Microsoft/go-winio/pkg/guid v0.4.14 does not build on linux

fejta opened this issue · 5 comments

fejta commented 
$ go build github.com/Microsoft/go-winio/pkg/guid
../../../go/pkg/mod/github.com/!microsoft/go-winio@v0.4.14/pkg/guid/guid.go:16:2: build constraints exclude all Go files in /usr/local/google/home/fejta/go/pkg/mod/golang.org/x/sys@v0.0.0-20190813064441-fde4db37ae7a/windows

Can we flag packages that we only expect to build on linux? AKA add a // +build windows line etc

$ grep -R "+build" ~/go/pkg/mod/golang.org/x/sys@v0.0.0-20190813064441-fde4db37ae7a/windows/*
/usr/local/google/home/fejta/go/pkg/mod/golang.org/x/sys@v0.0.0-20190813064441-fde4db37ae7a/windows/aliases.go:// +build windows
/usr/local/google/home/fejta/go/pkg/mod/golang.org/x/sys@v0.0.0-20190813064441-fde4db37ae7a/windows/aliases.go:// +build go1.9
/usr/local/google/home/fejta/go/pkg/mod/golang.org/x/sys@v0.0.0-20190813064441-fde4db37ae7a/windows/eventlog.go:// +build windows
jterry75 commented

@kevpar - PTAL

networkimprov commented

Please drop the x/sys/windows dependency.

See also golang/go#36485

  • 👍1
jterry75 commented

@kevpar - Can you take a look please?

  • 👀2
dtbartle commented

Looks like #169 is ready to be merged? Anything blocking that?

narph commented

any updates here? it all seems to be good to go in #169