microsoft/hermes-windows

App consuming Hermes is missing destructors

asklar opened this issue · 4 comments

asklar commented

When building a uwp app against hermes-windows I am finding that a bunch of functionality that is defined in jsi.cpp is missing from the dll. Namely, destructors for a lot of the types are missing, and all of the implementation for HostObject too.

Khalef1 commented

@mganandraj - can you follow up with @asklar here to understand the scenario and what we need to provide?

mganandraj commented

Hi @asklar Trying to cleanup the old issues in hermes-windows repo. Do you still need this looked into ? Thanks!

asklar commented

I haven't tried this recently. I think it would be useful to have some basic sanity test in the form of an app that only starts up a hermes engine and runs some JS (all separate from RNW).

mganandraj commented

I haven't tried this recently. I think it would be useful to have some basic sanity test in the form of an app that only starts up a hermes engine and runs some JS (all separate from RNW).

Agreed. We had such an app long time back!