microsoft/immersive-reader-sdk

Can't reopen Immersive Reader without refreshing if user exits early

livcheerful opened this issue · 3 comments

livcheerful commented

We just added Immersive Reader to the MakeCode Arcade tutorials, and we've noticed that if an error occurs between launching the Immersive Reader and displaying the content, and the user presses the back button, they won't be able to reopen it until they refresh (with an 'Immersive Reader is already launching' error).

For example, if a user loses internet connection while launching, they won't be able to launch again.

I did a local build of the SDK where I added isLoading = false to the exit function --

immersive-reader-sdk/js/src/launchAsync.ts

Line 134 in 60aaec3

reset();
, and it seems to fix it for our case! But let me know if we're calling the SDK incorrectly and this isn't a bug 😊 I am also happy to open a PR to contribute!

dylankil commented

@livcheerful Please do open a PR and target the dev branch!

  • 👍1
livcheerful commented

I put up a PR at #262 !

tylerthedeveloper commented

Closing as the PR was merged