microsoft/mu_tiano_plus

Restore DeviceSecurity Functionality

Closed this issue · 1 comments

makubacki commented

Is there an existing issue for this?

  • I have searched existing issues

Current Behavior

The DeviceSecurity code in SecurityPkg was intentionally removed in #272 and the libspdm submodule removed from the repo because it used an unreliable host (cryptomilk) for the cmocka submodule.

This means that currently the DeviceSecurity code is not built and the libspdm submodule in SecurityPkg is not available as expected.

Expected Behavior

That commit from that PR should be reverted to restore previous behavior when the host has been updated in libspdm, edk2 has updated the libspdm submodule, and that change can be cherry-picked back to SecurityPkg in Mu Tiano Plus.

Steps To Reproduce

View the changes in commit 11506d5 that resulted from PR 272.

Build Environment

All

Version Information

Commit: 11506d59b72515a8d561baddfa2bb6660924ad6e

Urgency

Medium

Are you going to fix this?

I will fix it

Do you need maintainer feedback?

No maintainer feedback needed

Anything else?

No response

makubacki commented

All upstream changes are done: