microsoft/onnxconverter-common

apply_relu6 was deprecated and remove.

xadupre opened this issue · 3 comments

It should first raise a warning telling it is going to be deprecated and be removed in release + 2.

Is there any production issue here? apply_relu6 on 5/31/2020 and rename it as apply_relu_6 on 6/1/2020, so deprecate apply_relu6 the same day. This is a really short period of time not in the middle of release.

these APIs could not be removed after release, it can only be upgraded by some new function like apply_relu2, apply_relu3 and so on. that's also the reason why apply_relu6 -> apply_relu_6.

It's interesting how you notice this quick change?

synced offline, the issue is gone.