microsoft/sarif-sdk

Add timeout to AnalyzeOptionsBase

marmegh opened this issue · 0 comments

Services using BinSkim and Sarif Pattern Matcher may utilize timeouts to prevent downstream issues. These timeout implementations lack insight into what processes within BinSkim/Sarif-Pattern-Matcher may have stalled or are taking too long. To improve isolation of root causes for timeout related bugs, it would be helpful to have a streamlined timeout mechanism which would likely be best implemented as part of the sarif-sdk. A strong candidate would be to include a timeout duration as part of the AnalyzeOptionBase and implement the timeout logic as part of the (Multithreaded)AnalyzeCommandBase. In the event that the timeout limit is exceeded, log a ToolNotification.