VS2019 fresh download of VSIX did not work for me
michaelcfanning opened this issue · 12 comments
@EasyRhinoMSFT, how about for you?
@michaelcfanning what error/issue did you see?
I refresh installed the marketplace SARIF viewer on VS 2019, it works for me.
Also clean installed the VS2019 VSIX built from latest main branch. It also works. Pls let me know what issue did you see thanks!
@EasyRhinoMSFT I cannot repo your issue neither... Ran the APEX tests all passed too. Wondering if its environment related. Feel free to setup a meeting/live session we can investigate more.
Worked with @EasyRhinoMSFT showed me the issue:
- Open VS 2019 installed the SAIRF viewer extension.
- Open a valid SARIF log file with results.
- SARIF explorer does not popup automatically
- Open SARIF explorer from menu 'View' -> 'Other Windows' -> 'SARIF Explorer', the explorer window is blank.
As I understand this is current viewer's behavior. Viewer does not open SARIF explorer after opening a SARIF log file.
Only when you navigate to the result in Error List pane (double click on the error list item), it will open SARIF explorer and populate information.
I found an old issue discussing about this behavior at #159. Please take a look.
We could show a message in the blank SARIF explorer "Select an error to see details" to the user.
I find this very weird. The original purpose of the viewer was to provide an enhanced interaction with SARIF logs with a UI that presents their details. The current behavior makes it almost completely invisible and difficult to discover.
I too am confused by the behavior here. This morning I downloaded and installed it on VS2019. I opened a valid SARIF file (works fine with the VSCode extension) but I don't see anything in the Error List or in the SARIF Explorer window. I even opened the Solution to which the SARIF file applies but I still don't see anything. My expectation is that I should see results for any SARIF file I open somewhere. Any logs or anything I can collect here?
My machine is still in this condition. I see that the extension is installed, 3.0.59.39815. I know that the viewer is partly operational: if I open a SARIF v1 file it queries me to see if I want to transform. And then, after this, silence. :)
@yongyan-gh, @EasyRhinoMSFT, with two customer reports, I trust there's some fire to this smoke. :) Would you like me to debug my system, if no one else on the team can repro?
@michaelcfanning can you please provide the log you are opening
can you pls share the visual studio log file at: %APPDATA%\Microsoft\VisualStudio\{vs_version}\ActivityLog.xml, and the sarif log file you opened when you saw the issue? Thanks
I ran VS2019 with the "/log" parameter, opened my solution, and then opened a SARIF file relevant to the solution (i.e. there are results in the file that apply to files in my solution). I opened a file that should have results on it, but didn't see any. I opened SARIF explorer but it was completely empty.
Here is the abridged activity log (reduced to just events related to the SARIF viewer and PII removed): AbridgedActivityLog.txt. It doesn't appear to be very enlightening, to my eyes anyway.
I cannot provide the SARIF log here as it's generated by an internal tool, but I could send it to @EasyRhinoMSFT internally (along with the full ActivityLog.xml). Let me know if that is acceptable.
OK, let's do follow up internally, this one is important.