microsoft/scalar

Scalar forces autocrlf=false and safecrlf=false for cloned repo

nikola-sh opened this issue · 1 comments

Scalar configures cloned repo with settings

[core]
    autocrlf=false
    safecrlf=false

It is explainable for VFSForGit, but it seems unnecessary for Scalar.

I would suggest to respect user and system git settings for CRLF transformation.

The auto-CRLF conversions do have a noticeable performance impact in large repos, so I believe that we will want to keep them enabled by default. Most users will have it enabled globally, so we need to override it locally.

However, the way we set them make it a required setting instead of optional. The best thing to do would be to move the setting from requiredSettings to optionalSettings, which will respect the choice if a user decided to change the setting in the local Git config, after the clone.