Convert all existing rules to use a `walk` function instead of extending AbstractRule

Question

JoshuaKGoldberg opened this issue 6 years ago · 4 comments

Partner to #586: following palantir/tslint#2522, we should be recommending a ts.forEachChild strategy.

Accepting any PRs that take an existing rule and convert it to walk! ✨

Answer 1 · 2018-12-18T16:27:42.000Z

The change in #682 to no-for-in is a good example of how to approach this 😊

Edit: whoops, allowed the PR to close the issue. Any other rules yet to be converted are still fair game!

Answer 2 · 2018-12-19T15:19:48.000Z

Reopening this issue because it tracks migration of all rules and was closed automatically with fixes #NNN text in PR text.

Note to reviewers: check if PR text strictly follows template and will close this one again.

Answer 3 · 2018-12-31T15:22:30.000Z

We're about halfway there! 😄

Answer 4 · 2019-08-13T03:28:44.000Z

Looks like this was accomplished. Thanks so much folks! 💖