microsoft/typescript-analyze-trace

Change exit codes to be more CI friendly

Jaspooky opened this issue · 2 comments

Currently, the tool states

Exits with code 0 if highlights were found, 1 if no highlights were found, and 2 if an error occurred

Using this tool within CI, a non-0 exit code typically causes the job to fail which doesn't feel congruent with "no highlights found" (which to my understanding means there's no noteworthy findings?)

Would it make sense to swap the 0 and 1 exit codes? Or to at least add an argument that swaps them?

TIA

I sorta feel like it should just exit 0 always unless something broke; then someone can grep the output if they're looking for some particular condition.

^ I agree. I thought something broke in my build, but I actually just made it faster