microsoft/vision-ai-developer-kit

Hardcoded Username/Password

toolboc opened this issue · 4 comments

toolboc commented

There is a hardcoded Username/Password of admin:admin at the following:

vision-ai-developer-kit/samples/official/camera-tagging/modules/CameraTaggingModule/CameraServerModule/scripts/mpeg4-stream.js

Line 174 in a939db6

const ffmpegParams = `-rtsp_transport tcp -y -i rtsp://admin:admin@${RTSP_IP}:${RTSP_PORT}/${RTSP_PATH} -vframes 1 -strftime 1 ${dataRoot}/${tag}/img-%m%d%y-%H%M%S.png`;

This should be removed, if a user needs to provide a username password combination it can be supplied in the RTSP_IP parameter as <username>:<password>@<rtsp_ip>

MS-Nikunja commented

@DavidGrob-V-MS Can you take a look at this.

DavidGrob-MS commented

@MS-Nikunja sure thing. I'll take a look.

v-prsasa commented

@DavidGrob-V-MS Hey David, Is there any update regarding this issue?

DavidGrob-MS commented

Pull request #310 from https://github.com/toolboc has been approved and has a fix for the issue