Extension hijacks "Toggle Block Comment" keyboard shortcut
Zache opened this issue · 3 comments
This extension registers the keyboard shortcut: Shift+Alt+A to open itself in sidebar of VSCode, but that keyboard shortcut is already used by the default configuration of VSCode as "Toggle Block Comment" that comments out your current selection.
To me this feels like bad manners, and I think you should change it.
Looking at the keyboard shortcuts it seems like focusing the different sidebars uses Ctrl+Shift and not Shift+Alt. Perhaps it's better to follow that pattern? Ctrl+Shift+A is already taken (but only works when a notification is focused or a toast visible), but I can see that GitLens has opted for a chord and selected Ctrl+Shift+G G instead of hijacking the default shortcut for "View: Show Source Control"
I agree that we should try to not overlap with the toggle block comment keybind.
What operating system are you using? I'm asking because I think this issue is specific to Windows or Linux. On macOS, we don't overlap with toggle block comment.
This is the configuration for our keybind:
{
"command": "workbench.view.extension.azure",
"key": "ctrl+shift+a",
"mac": "cmd+shift+a",
"linux": "shift+alt+a"
}
This has been fixed in #876