microsoft/vscode-codicons

Some Toolbar icons are not centered

pouyakary opened this issue · 5 comments

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.72.0
  • OS Version: 12.5.1

These two icons are not centered in the toolbar. This occurs everywhere:

Screen Shot 2022-10-10 at 4 52 50 PM

Screen Shot 2022-10-10 at 4 53 18 PM

I am happy to work on this issue if needed

Transferring to the Codicons repo.

Here's the basic problem. Codicons are built on an even pixel grid, which makes things challenging when you introduce elements that are supposed to sit directly in the middle.

Current icon, offset by design to account for this:

CleanShot 2023-05-01 at 15 35 06@2x

Here's how this looks if the container is perfectly even—you can't center the divider

CleanShot 2023-05-01 at 15 35 14@2x

I may consider changing this icon anyway, but wanted to share the immediate challenge that I saw.

Every time I mistake the problem for wrong padding and then arrive at this problem :) damn evens :))

Tracking in #243