Request for new icon for the"Opening Remote Repository" Scenario
bhavyaus opened this issue · 7 comments
Hi,
We have added a quick access icon on the primary side bar for Remote Repositories so that users can quickly open a remote github/azure repo. See #139
Currently, its the + icon which could confuse users since that implies "Adding/Creating" where as the action involved is "Opening"
Thank you!
Taking both open-folder and vm-connect icons as inspiration, here's what I propose (in welcome page context to show difference from open-folder. Thoughts?
Icons together for reference:
LGTM. It matches the remote explorer Activity Bar Icon. Any idea why the Remote Hub Extension Icon is
https://marketplace.visualstudio.com/items?itemName=ms-vscode.remote-repositories
I should probably change that up too.
cc: @joyceerhl
@daviddossett added that one in July this year microsoft/vscode-remote-repositories-github#209 (comment). I know we talked about doing a refresh of all the remote-ish extensions at some point though. The only concern I can think of is that the Open Remote Repository scenario does not take place over a remote connection, so that might be confusing to users (and is possibly why we went with the internet connection icon instead).
That's a fair point @joyceerhl. We can continue using that signal metaphor for this folder icon too. In fact, I don't know why I didn't think to use that icon here. Blame the Monday brain, I suppose.
It just needs to be modified for use at the "normal" codicon size.
A second pass:
@daviddossett added that one in July this year microsoft/vscode-remote-repositories-github#209 (comment). I know we talked about doing a refresh of all the remote-ish extensions at some point though. The only concern I can think of is that the Open Remote Repository scenario does not take place over a remote connection, so that might be confusing to users (and is possibly why we went with the internet connection icon instead).
But Remote Repositories is also accessible through the Remote Explorer which also is home to other remote development scenarios and that uses the >< symbols in the icon?
Yeah that's a good point--the Remote Repos view has always been in the Remote Explorer, and its primary value add is to ensure that users do not lose their uncommitted changes in repositories that they have opened before. Maybe this means we reconsider whether 1. we need the view and 2. the view fits in the Remote Explorer, especially if we are storing uncommitted changes with Edit Sessions.