l10n-dev misses Windows paths due to different path separator
TylerLeonhardt opened this issue · 1 comments
TylerLeonhardt commented
The glob library we use says that you have to use forward slash for paths... well I missed a place where we did this which, on Windows, caused backslashes to be passed in.
This made the library entirely miss code... and caused JS-Debug to lose all of the strings:
https://monacotools.visualstudio.com/Monaco/_build/results?buildId=212737&view=logs&j=8c879edf-dd07-5381-7169-8a53b5545052&t=7e9656d4-c55b-55d4-3dff-61157bfdebe1&l=25
TylerLeonhardt commented
verification:
- https://github.com/microsoft/vscode-extensions-loc/blob/main/src/en/ms-vscode.js-debug/ms-vscode.js-debug-new.xlf has the
bundle
strings at the top of the file - build picked up TypeScript files: https://dev.azure.com/monacotools/Monaco/_build/results?buildId=212940&view=logs&j=8c879edf-dd07-5381-7169-8a53b5545052&t=7e9656d4-c55b-55d4-3dff-61157bfdebe1&l=25