Remove "Uncomitted Changes" in timeline

Open a GH/Azure Repos repository on https://insiders.vscode.dev
Open and file, and open the timeline view
Ensure that both Git and Local History entries are shown
Make a change to the file and save
- Local History entry is added to the top of the list
- Local History entry is then moved under "Uncommitted Changes" entry

Just in case: this is not specific to web version and can be reproduced in Desktop as well.

I think this works as designed: the "Uncommitted Changes" from Git is probably always updating when you save and is more recent than the actual save event.

@JacksonKearl would you agree this works as intended?

Roughly as designed, but could be smoother. Maybe if we had a way to denote at an API level that an event is "current" rather than historical. Or maybe we shouldn't even have the "uncommitted changes" entry now that we have local file history.

I agree, I don't think "uncommitted changes" should be a history entry at all. It's not a historical event. You might have uncommitted changes, but itself is not a change like everything else the timeline shows. Perhaps have a "diff" action in the Timeline title instead.

I really like the idea to not have "Uncommitted Changes" at all. It seems to originate from the git extension:

vscode/extensions/git/src/timelineProvider.ts

Line 228 in 2626c7f

    
           const item = new GitTimelineItem('', index ? '~' : 'HEAD', localize('git.timeline.uncommitedChanges', 'Uncommitted Changes'), date.getTime(), 'working', 'git:file:working');

Especially now that we have local history enabled, there will always be an entry for local history above the last committ, so the information is redundant.

Lets do this.

@joyceerhl not sure whether we want to remove those for remotehub extension as well:

https://github.dev/microsoft/vscode-remotehub/blob/68fa1962af31c0d1b84044735feff2d98af32a4b/extensions/remotehub/src/timelineProvider.ts#L126-L128

@bpasero Removed the Uncommitted Changes timeline entries for RemoteHub. I kept the Staged Changes timeline entry though, since that is a historical event and it looks like we also kept those for the git extension.

Thanks!

This change has actually caught me off guard. While I like the idea for the "Local History" in general, It's sometimes too granular and I'd like to view all the changes since the last commit. Imho, the "Uncommited Changes" entry should be shown when "local history" is disabled, or it should be configurable by settings.

Can you report a new feature request for this?