microsoft/vscode

Error telemetry: always start to deminify stacks

bpasero opened this issue · 2 comments

bpasero commented

I think there is no reason to click on an error in telemetry and not run the deminification, so why not just start it right when clicking on an error?

ramya-rao-a commented

True, for a given vscode version, there is only 1 call to make to get the source maps which we can do upfront.

  • 👍1
ramya-rao-a commented

Fixed with https://monacotools.visualstudio.com/Monaco/_git/VSCodeInternal/commit/6a7215d271a6256ccb8d59a378e5fc03504967ef

Hard refresh to get rid of cache to see the changes

Correction on #15752 (comment) :
Call to get sourcemaps is made once for each file in the callstack not once for each vscode version.
If the same file occurs in multiple error call stacks, then the call is not made again as long as you are in the same session

  • 🎉1