Clicking on a view node's arrow (from TreeDataProvider) to expand it shouldn't execute its command
eamodio opened this issue · 3 comments
eamodio commented
- VSCode Version: Code - Insiders 1.14.0-insider (bbcd10a, 2017-06-13T05:13:35.880Z)
- OS Version: Windows_NT ia32 10.0.16215
Or something. :) It's probably best to not have commands on expandable nodes but if you do, it definitely feels odd that it executes and expands. Maybe the arrow could be its own hit target?
sandy081 commented
@eamodio Extensions can always opt out by not giving commands to those items. Do you think there is another case which I am missing here?
eamodio commented
@sandy081 not really -- its probably just best to not have a command on something that expands -- at least on single-click as it is now
sandy081 commented
Ok. Closing for now since I do not see any usecase for not providing this. Will reopen based on more feedback. Thanks.