microsoft/vscode

JSON: workspace.rootPath is deprecated

Closed this issue · 3 comments

joaomoreno commented

Testing #39568

image

aeschli commented

@dbaeumer The language server client does that. I wonder if we should add a configuration setting to the language server client to signal that the server doesn't need it, or a rule to our extension profile tooling to ignore it.

dbaeumer commented

@aeschli having a setting for this sounds wired. What if there is another deprecated API. Should I leave that out as well then.

I think what we can do is to use workspaceFolders[0] which is equal to rootFolders. Opened microsoft/vscode-languageserver-node#285

aeschli commented

Closing then, all is fine here.