microsoft/vscode

parameter highlight

bichikim opened this issue · 10 comments

The image below is highlighting codes in Vscode now
image

I hope the parameters in the function are highlighted as shown below.

image

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

This looks like it's caused by an extension. I cannot reproduce this.

This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the marketplace for VS Code. See also our issue reporting guidelines.

Happy Coding!

@alexr00 Hi

The second image is function code in Webstorm.

Webstorm can find the parameter name in the function. It would be nice if Vscode supports a theme color scope such as "variable.parameter ..." for the parameter values.

I'm looking at the first image, and I'm not seeing the same syntax highlighting that is in your example. My example in VS Code:
image

@alexr00 thank you for your time

your image is the same image as mine if you add code below to settings.json

            {
                "scope": [
                    "variable.parameter",
                ],
                "settings": {
                    "foreground": "#9AD100",
                    "fontStyle": "",
                }
            },

Vscode does not know whether "value" or "parameter" is "const" or "parameter" so Vscode highlights "values" and "parameters" of the same color.

But Webstorm does know that so parameter and value are not the same color at my second image.

Highlighting two variables in a different color helps to determine which is the parameter.

I ask the Vscode team to add this feature

This is a change request for the TypeScript TextMate grammar we use then. In this example on lines 2 and 4, parameter and value are both variable.other.readwrite.ts. The change would be to categorize these differently.

function myTest(parameter: any) {
	console.log(parameter);
	const value: string = 'value';
	console.log(value);
}

Actually, I don't think this is possible with TextMate. Duplicate of #50140.

B2o5T commented

@alexr00 thank you for your time

your image is the same image as mine if you add code below to settings.json

            {
                "scope": [
                    "variable.parameter",
                ],
                "settings": {
                    "foreground": "#9AD100",
                    "fontStyle": "",
                }
            },

Vscode does not know whether "value" or "parameter" is "const" or "parameter" so Vscode highlights "values" and "parameters" of the same color.

But Webstorm does know that so parameter and value are not the same color at my second image.

Highlighting two variables in a different color helps to determine which is the parameter.

I ask the Vscode team to add this feature

that's the only reason I can't go over from WebStorm to VSCode, this is overkill ☝️

@alexr00 thank you for your time
your image is the same image as mine if you add code below to settings.json

            {
                "scope": [
                    "variable.parameter",
                ],
                "settings": {
                    "foreground": "#9AD100",
                    "fontStyle": "",
                }
            },

Vscode does not know whether "value" or "parameter" is "const" or "parameter" so Vscode highlights "values" and "parameters" of the same color.
But Webstorm does know that so parameter and value are not the same color at my second image.
Highlighting two variables in a different color helps to determine which is the parameter.
I ask the Vscode team to add this feature

that's the only reason I can't go over from WebStorm to VSCode, this is overkill ☝️

I think so.