Changes to .github/workflows/build.yml break other repos
Closed this issue · 2 comments
https://github.com/microsoft/netperf/actions/runs/11231253686
This change broke https://github.com/microsoft/netperf/blob/main/.github/workflows/ebpf.yml
@mtfriesen Can you please make sure to either fix all repos that depend on this if you make a breaking change like this (or at least inform dependent teams that there is a breaking change).
@Alan-Jowett sorry, I forgot that eBPF is also using that workflow. One option is for ebpf to take a dependency on build.yml@[commit] instead of build.yml@main and using dependabot keep the dependency up-to-date, but this still leaves the possibility of build.yml being broken by newer code changes.
I'm not sure the best way to keep track of all possible external dependencies - perhaps we should create a Discussion thread for each GitHub-related breaking change, and dependent developers can set up watch rules?
Resolving this external for now, because the cleanest solution of relying on build.yml@commit to dynamically build XDP commit is not possible in GitHub actions today. We will try to avoid breaking changes and inform dependent teams.