microsoftgraph/msgraph-sdk-dotnet-core

Evaluate improving batching support

maisarissi opened this issue · 4 comments

maisarissi commented

Evaluate improving batching support based on the work @svrooij did here.

We could integrate this in the .NET core library and also evaluate a similar approach for all other languages we support.

By the way, incredible work @svrooij. Kudos!

svrooij commented

Thanks for the compliment @maisarissi I was not sure if this would be something that you would consider to be implemented in the main library. Hence the fact of me creating an extension library.

Our company is probably one of the big time users of batching (we even build a custom in-house graph client because the official client did not support batching just yet).

If you're open for this change, I can convert the code to a PR? Would need some help creating the tests for it though. But until then users can just install my extension from nuget. And have better batching support from the start.

  • ❤️1
maisarissi commented

Yes! Absolutely @svrooij .

We would love to get this as a PR. Our engineering team can review it and collaborate with you in case any changes are needed as well as help creating tests.

bwosborne2 commented

@maisarissi
Has there been any consideration of adding something similar to the PHP SDK?

maisarissi commented

Hi @bwosborne2 , for PHP implementation you can follow the issue microsoftgraph/msgraph-sdk-php-core#129