Confusing Active hours
Opened this issue · 3 comments
Description:
Active hours generated in our github unwrapped seem confusing. We don't know the time zone it uses. It should either use our timezone from github or provide us the context (Like 11am IST). I'm not sure of the current implementation but categorizing "night owl" with most active hour as 11 am conflicted with the other unwrap I generated from githubunwrapped.com which gave around 2 am.
Steps to reproduce:
- Generate your unwrapped
- Check the day night cycle stat
Expected behavior:
Some context
Actual behavior:
No context
@narayan954 We calculate the day night stats based on the opened PR timings while githubunwrapped.com does it using commits, hence this difference in data. Thanks for opening this issue, the cards wordings can be improved to convey what it shows, or we can maybe update the underlying logic.
@narayan954 We calculate the day night stats based on the opened PR timings while githubunwrapped.com does it using commits, hence this difference in data. Thanks for opening this issue, the cards wordings can be improved to convey what it shows, or we can maybe update the underlying logic.
Great, now I understand! perhaps it'd be better if we update wordings to something like "Most PRs opened around". That'd be clearer, because I make commits mostly around 2 am only and most of those commits don't go into PRs. Or as you said updating underlying logic could be better because commits convey more than a PR does.
Great, now I understand! perhaps it'd be better if we update wordings to something like "Most PRs opened around". That'd be clearer, because I make commits mostly around 2 am only and most of those commits don't go into PRs. Or as you said updating underlying logic could be better because commits convey more than a PR does.
@narayan954 Thanks for the feedback, we will move to commits soon.