middlewares/uuid

RFC: Rename to Request-Id

marijn opened this issue · 3 comments

marijn commented

Thanks for making an effort in building up the PSR middleware ecosystem.

I was wondering why you choose to name this package UUID. It seems its more about assigning identity to individual requests than about the particular ID used.

oscarotero commented

This middleware not only identify the request but also the response returned, so it's usefult for debug purposes. The UUID specification guarantee uniqueness across space and time, so I think it's a good name to identify a request->response cycle.

Thoughts @middlewares/contributors ?

shadowhand commented

I think it would be good to rename this package, or have a separate middlewares/request-identity package that would allow for both UUID and custom identifiers via interface:

interface RequestIdentityInterface
{
    public function getRequestIdentity(Request $request): string;
}

This interface would be useful in situations where the request identity could be provided via a header or other other means.

  • 👍1
oscarotero commented

I don't know if it's possible to rename this package without break other things (like dependents). If it's problematic, a new package that deprecates this could be ok.