migtools/crane-operator

securityContext warnings on 4.11

Closed this issue · 12 comments

jmontleon commented

Editing any of our deployments complains about these not being set. We probably need to update the configs with these values or whatever is appropriate.

spec:
  template:
    spec:
      containers:
        securityContext:
          allowPrivilegeEscalation: false
          capabilities:
            drop:
            - ALL
      securityContext:
        runAsNonRoot: true
        seccompProfile:
          type: RuntimeDefault
eriknelson commented

/priority critical
/kind bug
/triage accepted

openshift-ci commented

@eriknelson: The label(s) triage/accepted cannot be applied, because the repository doesn't have them.

In response to this:

/priority critical
/kind bug
/triage accepted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

eriknelson commented

/triage accepted

jmontleon commented

@djzager what's the right way to do this with crane-runner?

djzager commented

@djzager what's the right way to do this with crane-runner?

I'm not certain that we need it for crane-runner since there is no deployments...just tasks (that get run as pods). Maybe this is something that would be added by the Tekton controller at run time?

jmontleon commented

I think that makes sense, if it's not something we control.

jmontleon commented

I believe all of the PRs above are merged.