migtools/oadp-non-admin

if backupSpec is not valid, link documentation

kaovilai opened this issue · 6 comments

kaovilai commented

The link would show up in status message of NAB/NAR error/warnings.

could be ENV that can be overridden in downstream CSV etc.

The link could be short link that can be dynamically updated in the future.

mateusoliveira43 commented

which documentation would we link today ❓ for example

mateusoliveira43 commented

is not this a OADP (or Velero) enhancement ❓ Can you give an example of a problem that would only happen in NAC, but not in OADP ❓

mpryc commented

It is kind of both.

  1. The VeleroBackup within NonAdminBackup is incorrect (currently it's empty case only, but we will add namespace checking and possibly other checks). In this case only NAB object will know that something is wrong, because VeleroBackup will never be created in a first place. This is easy as we will have pre-check to find out if the VeleroBackup config aligns with NAB requirements.
  2. The VeleroBackup got created as it was accepted by the NonAdminBackup, but the logs in VeleroBackup object indicates that something is wrong. We could consider adding another condition to a NonAdminBackup stating about configuration errors. This one is a bit more challenging, because not all errors in logs tells that config are not OK.