miguelcobain/ember-leaflet

Path error in template layout call using octane blueprint

gilles-bertrand opened this issue · 14 comments

gilles-bertrand commented

Hi, in the last version when you use the component, we receive this error

Error: Could not find module ember-leaflet/templates/leaflet-map imported from ember-leaflet/components/leaflet-map

To correct this I had to change the line 10 of the components/leaflet-map.js to take the current in path

miguelcobain commented

@gilles-bertrand what ember-cli version are you using?
Are you using ember octane blueprint?

gilles-bertrand commented

@miguelcobain yes indeed do I need to do somthing specific

miguelcobain commented

As far as I can tell this is a bug on that ember-cli version.
I had to use the latest released ember-cli version and it worked fine.

miguelcobain commented

It might be worth to create an issue in ember-cli's repo.

gilles-bertrand commented

Ok I've bumped my ember cli to the new version
But now I receive this error when I add layers

TypeError: func is not a function

Any idea why ?

miguelcobain commented

@gilles-bertrand i specified "ember-cli": "3.8.3" in my package.json, and it worked.

Didn't try with later versions. :(

backspace commented

There’s some discussion of this problem here.

jelhan commented

Ember CLI 3.13.0 was released without a bug fix. Ember Leaflet is currently broken on Ember CLI 3.13. Ember Bootstrap was also affected by this bug. This is the fix we landed there: ember-bootstrap/ember-bootstrap#883 It's not beautiful but it seems to work quite stable.

nummi commented

Still seeing this in 3.14.0-beta.2.

m3l1x commented

@miguelcobain do you consider to merge @backspace 's PR #342?

jelhan commented

@miguelcobain do you consider to merge @backspace 's PR #342?

@m3l1x I think #342 would introduce a breaking change as it drops support for Ember CLI <= 3.12. So i might not be mergeable in it's current state unless a new major release is fine for miguelcobain...

Please note that this is only blocking Ember CLI upgrade. You can use ember-source@~3.14.0 with all it's amazing Octane features together with ember-cli@~3.12.0

  • 👍1
backspace commented

I wouldn’t propose a breaking change for something like this. If anyone has time to amend my PR to also work on older Ember CLI versions, that would be great. I don’t know when I’ll be able to get back to this.

nummi commented

Please note that this is only blocking Ember CLI upgrade. You can use ember-source@~3.14.0 with all it's amazing Octane features together with ember-cli@~3.12.0

Unfortunately this did not work for me. Setting "ember-cli": "3.12.0". No errors in the CLI or browser console — nothing renders. Probably something specific with my app.

miguelcobain commented

Should be fixed in ember-leaflet 4.0.0

  • ❤️1