miguelcobain/ember-leaflet

Ember 5.x+ Support

mdconaway opened this issue · 2 comments

mdconaway commented

Hi, and thanks for this great Ember addon!

I recently installed ember-leaflet in an Ember 5.2 based application, and while the addon works perfectly well in Ember 5.x, the addon causes NPM install to fail unless it is run manually using the --legacy-peer-deps flag.

This is because the addon specifies ember as a peer dependency here: https://github.com/miguelcobain/ember-leaflet/blob/master/package.json#L93

I can open a pull request to update this peer dependency value if required, or the primary maintainers of this repository could simply patch the package.json. I believe package.json simply needs to be altered to support Ember 4.x+ and 5.x+ as a peer dependency and then the addon will continue to work with the latest major version of Ember using ember install.

Thanks!

miguelcobain commented

@mdconaway a PR would be very welcome :)

mdconaway commented

PR opened here: #686

Please note, this will require this other pull request to be merged too: canufeel/ember-leaflet-marker-cluster#48

Thanks!