miguelhincapie/CustomBottomSheetBehavior

TODO

Opened this issue · 5 comments

miguelhincapie commented

TODO:

  1. MergedAppBarLayoutBehavior still not showing properly when
    BottomSheet starts in EXPANDED mode.

  2. ScrollingAppBarLayoutBehavior not showing properly the status bar if
    you start the BottomSheet in STATE_COLLAPSED.

  3. If BottomSheet content’s height is smaller than screen height, when
    you scroll the BottomSheet (going to expand mode) you can see the
    map/background behind BottomSheet element.

miguelhincapie commented

Point 2 ready.
Point 1 need to fix a little initial state in status bar.

vit001 commented

For point 1 - I think it's fixed in my fork.
For point 2 - I think it's fixed in my fork.
For point 3 - you can set a minHeight on the top-most layout inside the NestedScrollView. Alternatively, it can be resized at runtime based on the measured NestedScrollView height.

miguelhincapie commented

Ty!
About point 3, what you said is what exactly I'm doing :D, but should be nice have a default behavior that can be override if you don't want it, in where it auto-resize the bottomSheet... but it's a low priority for me.

miguelhincapie commented

I wish this project be up dated with all those nice improvements you did. Could you merge them?

vit001 commented

My fork only works with the BottomSheets in a ViewPager (the fling didn't work right without it and I don't have time to figure out why). So I can merge them but it requires a (breaking) change to the layout to include the ViewPager. It also requires providing an adapter for the ViewPager, but that is easy and can include just one item (so there is no paging). Let me know if you are OK with those breaking changes and I will issue a PR.