miguelsolorio/vscode-symbols

[contribution] Add icons

Closed this issue ยท 5 comments

Hello!

Congratulations for this very nice extension and icons design. ๐Ÿ”ฅ๐Ÿ‘ it's my favorite so far.

I want to contribute with some icons, followed the contribution guide and used colors from the existing icons (Pinia stores one was a bit demanding).

image

Please provide tips on what to improve, before actually submitting a pr. Thanks.

@angelhdzmultimedia thanks for your interest in contributing to the project! I think what would be best if to create a PR for these changes so that I can inspect the icons more closely. I do have some guidelines I am following to keep the icons consistent (need to publish these).

I'm a little hesitant about the Nest + Quasar + Pinia (the folder color change) since those appear to be visually heavy. I think with some minor tweaks this can get better but just wanted to let you know. Feel free to create a PR and we can get started!

I'll go ahead and close this issue since you've added in your PRs. Thanks again!

Hey! Thanks for replying and sorry for the delay.

I closed the PRs because I sent them without reading the Contribution Guidelines ๐Ÿ˜‚๐Ÿ‘€ woops! ๐Ÿคฆโ€โ™‚๏ธ

I will soon read them thoroughly, and follow them to submit the icons.

In the meantime, I harcoded all the icons in the extension installation directory and they look great on my dark theme.
I love designs with high saturation, vibrant.